Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PianoRoll Component Missing #35

Closed
markjamesm opened this issue Dec 24, 2021 · 3 comments
Closed

PianoRoll Component Missing #35

markjamesm opened this issue Dec 24, 2021 · 3 comments

Comments

@markjamesm
Copy link

markjamesm commented Dec 24, 2021

I'm trying to follow this example to use the PianoRoll, but I'm getting the following error:

Compiled with problems:
ERROR

src\SynthEngine.js
  Line 25:10:  'PianoRoll' is not defined  react/jsx-no-undef

Looking inside the Reactronica source I don't see a PianoRoll in the components.

@markjamesm
Copy link
Author

I run into the same issue with the Keyboard component as well:

Compiled with problems:

ERROR in ./src/SynthEngine.js 17:36-44

export 'Keyboard' (imported as 'Keyboard') was not found in 'reactronica' (possible exports: Effect, Instrument, Song, Track, config)

@brandongregoryscott
Copy link

brandongregoryscott commented Jan 19, 2022

Hey @markjamesm - I'm not sure these examples are meant to be copied directly. They are examples of what can be built using the underlying primitive components (Song, Track, Instrument and Effect), but no GUI components are exported. If you look through the git history you might be able to find versions of those components/examples. (This is a link to an early version of the DAW example https://github.com/unkleho/reactronica/blob/v0.4.6/website/components/DAWApp/DAWApp.tsx)

@unkleho
Copy link
Owner

unkleho commented Jan 20, 2022

@markjamesm - I should update the docs to make it clearer - here is the piano roll if yr interested:
https://github.com/unkleho/reactronica/blob/v0.4.6/website/components/DAWStepsEditor/DAWStepsEditor.tsx

@unkleho unkleho closed this as completed Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants