Hotkey interface implementation #2070

cmocanu · 2013-04-06T11:11:14Z

This partially fixes #1964 and #1893.
I managed to implement a workable interface for binding hotkeys. Although it is currently usable, there are some places where it could be improved:

the settings only take effect after restarting the game
the key names are sorted by length ( I have no idea why this happens, and could not find a fix)
key combinations are not supported: the interface actually stores a the list of pressed keys, but I don't know how to set them, and combinations might create other problems as well
there is currently no way of deleting bindings (only overwriting): I didn't know how to implement this; let me know if you have any suggestions

If the user tries to bind a key which already has a binding, instead of simply removing the old binding, I bind the key binded to the current action to the other action. This is done to prevent having an action without a corresponding key, which is currently not supported by the hotkey implementation.

The problem is that now major modifications to the apply_changes function must be made, and there are some cases in which it's not very clear what to do.

This is done to make it possible to get the actions list properly ordered.

This is not working properly: the listener only detects keypresses when no button has focus and the F keys still aren't properly detected. Also, the listener is used all throughout the main menu, breaking F9 in the first screen.

squiddy · 2013-04-06T11:28:29Z

horizons/gui/modules/hotkeys_settings.py

+		container = self.widget.findChild(name='keys_container')
+		button_container = self.widget.findChild(name='button_container')
+		sec_button_container = self.widget.findChild(name='sec_button_container')
+		for i in range(len(self.actions)):


The better way to handle this in idiomatic python is to use enumerate.

for i, action in enumerate(self.actions):

Don't you dare merge this into production as-is ;-)

… keys.

cmocanu · 2013-05-02T06:05:27Z

After using ChrisOelmueller's hack to place the Hotkeys interface in the Settings menu and making the listeners work, there's only one problem left: I need to call some methods on Confirm and Reset to Default, but those buttons seems to be handled by FIFE, not pychan. Is there any way I could do this?
Also, I'd like to know if it's possible to create confimation pop-ups in the settings window ( Reset to Default seems to be able to do that, but again, it's done in FIFE).

squiddy · 2013-05-02T09:02:30Z

Also, I'd like to know if it's possible to create confimation pop-ups in the settings window ( Reset to Default seems to be able to do that, but again, it's done in FIFE).

I'm (kinda) working on rewriting the settings entirely, so I wouldn't concentrate too much on this one. It definitly will be possible then. And it's not done in fife, but here: https://github.com/unknown-horizons/unknown-horizons/blob/master/horizons/engine/settingsdialog.py#L65

…tkey_interface.py. This was done by storing the HotkeyConfiguration in the settingsDialog and calling te corresponding methods before calling applySettings() and setDefaults() from the settingsDialog.

cmocanu · 2013-05-03T10:45:27Z

Okay, I think it works now. Please let me know if you find any problems or if you think I did something (too) stupid in the code.
Also, we need to decide what to put in the Help menu.

squiddy · 2013-05-03T11:37:31Z

horizons/gui/widgets/pickbeltwidget.py

@@ -22,6 +22,7 @@
 from fife import fife

 from horizons.util.python.callback import Callback
+from horizons.gui.modules.hotkeys_settings import HotkeyConfiguration


This import looks obsolete.

stubb · 2013-05-03T12:03:53Z

Can you please merge the master branch in your branch, so it's possible again to test your branch with the last git version of fife and merging your PR will works too after that.

Conflicts: horizons/gui/keylisteners/keyconfig.py horizons/gui/widgets/pickbeltwidget.py

If the text of a button is "Press any key" and the user clicks another button, the interface should update the text of all buttons, so that no two buttons contain the text "Press any key" at the same time.

stubb · 2013-05-07T09:34:13Z

I noticed three things which should be fixed in my opinion before merging:

CONSOLE should be renamed to -> SHOW_FPS
A confirmation would be nice if a key is already in use
And the third is already fixed while writing this comment.

ChrisOelmueller · 2013-05-07T10:14:24Z

Hotkey interface implementation Great work ThePawnbreak!

stubb · 2013-05-07T10:16:48Z

Great work!

cmocanu added 28 commits March 19, 2013 01:00

Set up a crude interface for hotkey modification

c777b04

Make hotkeys actually work ingame; duplicates not supported

0ca2cb9

Added basic detection of duplicate keys

27d1e85

Add OK button

31b6ff7

Add remove_key_from_action function to engine

2d0e438

Implement basic duplicate detection. Clean up code

1c5736b

Add button for resetting keybindings to default.

ed2f32b

Add confirmation for replacing keys. Add secondary buttons

96f87c7

Bind events to secondary buttons.

736e138

The problem is that now major modifications to the apply_changes function must be made, and there are some cases in which it's not very clear what to do.

Add replace_key_for_action to engine.py

2b84642

Rewrite apply_change to support UNASSIGNED keys

449071e

Clean up hotkey_settings.py

a9f3016

Replace UNASSIGNED with - in GUI

ee13868

Use itervalues with dict

c2cc1ce

Make pressing Cancel in Confirmation dialog actually cancel rebind

f4b0a1a

Use ext.Enum for _Action in keyconfig.

7c56c3f

This is done to make it possible to get the actions list properly ordered.

Add get_actions_by_name method

3967506

Order actions by category in hotkey interface

3984590

Add listener for hotkeys window.

cdae29a

Use hotkey_listener in the Hotkeys interface.

f65fd56

This is not working properly: the listener only detects keypresses when no button has focus and the F keys still aren't properly detected. Also, the listener is used all throughout the main menu, breaking F9 in the first screen.

Move HotkeyListener to hotkey_settings.py

b353d7c

Add support for F keys in hotkey interface.

3af501c

Make hotkey_listener active only in the hotkeys interface

384309e

Do some clean up.

c82bbc2

Fix indentation in hotkeys.xml.

d6a2715

More cleanup.

f0949e7

Remove LivingObject from HotkeysListener.

c5669ce

squiddy reviewed Apr 6, 2013
View reviewed changes

ghost assigned ChrisOelmueller Apr 8, 2013

cmocanu and others added 7 commits April 8, 2013 16:56

Remove label generation in code.

ee6397d

Fix key configuration updating.

45c094a

Escape is now used to remove a key binding.

6d26381

Remove DEBUG and ESCAPE from list of bindable actions.

03473d1

Hack hotkey window into settings

e89ba55

Don't you dare merge this into production as-is ;-)

Make listeners work in the pickbelt.

c379f21

Change key binding behavior to not ask for confirmation for replacing…

d931bbd

… keys.

cmocanu added 3 commits May 3, 2013 12:58

Confirm settings and reset to default call coresponding methods in ho…

8c69081

…tkey_interface.py. This was done by storing the HotkeyConfiguration in the settingsDialog and calling te corresponding methods before calling applySettings() and setDefaults() from the settingsDialog.

Clean up some imports

33eb282

Add comments and do some clean-up.

fe209de

squiddy reviewed May 3, 2013
View reviewed changes

cmocanu added 2 commits May 3, 2013 20:30

Merge branch 'master' into hotkeys.

fb89247

Conflicts: horizons/gui/keylisteners/keyconfig.py horizons/gui/widgets/pickbeltwidget.py

Fix button text when the user clicks two buttons consecutively.

49d270f

If the text of a button is "Press any key" and the user clicks another button, the interface should update the text of all buttons, so that no two buttons contain the text "Press any key" at the same time.

cmocanu added 4 commits May 7, 2013 12:48

Add confirmation for replacing keys in hotkey interface.

48646db

Fix size of button changing after showing popup.

4cde0e5

Replace CONSOLE with SHOW_FPS in the hotkey interface.

1eb9522

Refactor two ugly lines into one more Pythonic one.

0a1d0be

squiddy added a commit that referenced this pull request May 7, 2013

Merge pull request #2070 from unknown-horizons/hotkeys

a4130db

Hotkey interface implementation Great work ThePawnbreak!

squiddy merged commit a4130db into master May 7, 2013

cmocanu mentioned this pull request May 7, 2013

Move the key configuration to the settings menu #1911

Closed

nihathrael deleted the hotkeys branch May 7, 2013 11:07

stubb changed the title ~~Hotkey interface implementation~~ Hotkey interface implementation Jan 31, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hotkey interface implementation #2070

Hotkey interface implementation #2070

cmocanu commented Apr 6, 2013

squiddy Apr 6, 2013

cmocanu commented May 2, 2013

squiddy commented May 2, 2013

cmocanu commented May 3, 2013

squiddy May 3, 2013

stubb commented May 3, 2013

stubb commented May 7, 2013

ChrisOelmueller commented May 7, 2013

stubb commented May 7, 2013

Hotkey interface implementation #2070

Hotkey interface implementation #2070

Conversation

cmocanu commented Apr 6, 2013

squiddy Apr 6, 2013

Choose a reason for hiding this comment

cmocanu commented May 2, 2013

squiddy commented May 2, 2013

cmocanu commented May 3, 2013

squiddy May 3, 2013

Choose a reason for hiding this comment

stubb commented May 3, 2013

stubb commented May 7, 2013

ChrisOelmueller commented May 7, 2013

stubb commented May 7, 2013