Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary period from basename. #35

Merged
merged 1 commit into from
May 16, 2020
Merged

Remove unnecessary period from basename. #35

merged 1 commit into from
May 16, 2020

Conversation

s-andro
Copy link
Contributor

@s-andro s-andro commented May 16, 2020

ext includes leading period.

unknownbrackets
unknownbrackets approved these changes May 16, 2020
View reviewed changes
Copy link
Owner

@unknownbrackets unknownbrackets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, you're right. Good catch.

Looks like this was affecting filenames like "foo.bar.iso".

-[Unknown]

@unknownbrackets unknownbrackets merged commit 9577435 into unknownbrackets:master May 16, 2020
@s-andro s-andro deleted the fix-basename branch May 16, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unknownbrackets unknownbrackets unknownbrackets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s-andro @unknownbrackets