Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search result headers don't appear on some Windows/Chrome computers #1295

Closed
ericras opened this issue Apr 4, 2019 · 9 comments
Closed

Search result headers don't appear on some Windows/Chrome computers #1295

ericras opened this issue Apr 4, 2019 · 9 comments

Comments

@ericras
Copy link
Member

ericras commented Apr 4, 2019

image

@ericras
Copy link
Member Author

ericras commented Apr 4, 2019

Someone showed me a similar issue on her laptop at a meeting last week. When I used Chrome’s “private” mode on her laptop it was ok, so I chalked it up to a setting or browser extension on her computer (like an Ad Blocker or something).

@ericras
Copy link
Member Author

ericras commented Apr 4, 2019

On that machine, it looked like the headings weren't even in the markup at all. (They were not hidden)

@mwolff-unl
Copy link

mwolff-unl commented Apr 9, 2019

Firefox will have the issue sometimes too.

image

I feel like it might have to do with something corrupt or incorrect in a user's cookies. I haven't been able to reproduce it since clearing everything.

@ericras
Copy link
Member Author

ericras commented Apr 9, 2019

@mwolff-unl you may be right, it may be a cookie thing and not an extension thing. If you're able to further isolate it, it would be appreciated.

@ericras
Copy link
Member Author

ericras commented Apr 9, 2019

I was able to make it happen but nothing stood out about the cookies compared to successful loads
Screen Shot 2019-04-09 at 5 20 53 PM
Screen Shot 2019-04-09 at 5 21 02 PM

@ericras
Copy link
Member Author

ericras commented Apr 9, 2019

I've figured out a couple things.

Good and bad loads have different markup.

  • Good load: table.gsc-table-result
  • Bad load: div.gsc-table-result

The title that we are displaying is not present at all in the bad load. There is a second title that we are hiding that is present in both versions.

We could reverse these two rules:

.unl .gsc-control-cse .gs-result .gsc-table-cell-snippet-close > .gs-title * { font-size: 1rem }

.unl .gsc-thumbnail-inside { display: none }

@ericras
Copy link
Member Author

ericras commented Apr 9, 2019

in addition .gs-web-image-box change to margin-right: 1em; and change .unl .gs-snippet to margin-top 0

@ericras
Copy link
Member Author

ericras commented Apr 9, 2019

I think its random chance what version of markup we get when we create a custom search engine on the fly. (once a user has loaded it, they keep getting the same on until they clear cookies)

bad on the left, good on the right

Screen Shot 2019-04-09 at 6 43 40 PM

@ericras
Copy link
Member Author

ericras commented Apr 10, 2019

@ericras ericras closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants