New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore button cursor lost in normalize.css update #1075

Merged
merged 2 commits into from May 30, 2017

Conversation

Projects
None yet
2 participants
@skoolbus39
Member

skoolbus39 commented May 30, 2017

cursor: pointer was removed in a recent update to normalize.css. This commit restores the style for buttons and related form elements.

Restore button cursor lost in normalize.css update
`cursor: pointer` was removed in a recent update to normalize.css. This commit restores the style for buttons and related form elements.

@skoolbus39 skoolbus39 added the CSS label May 30, 2017

@skoolbus39 skoolbus39 requested a review from tlemburg May 30, 2017

Show outdated Hide outdated wdn/templates_4.1/less/layouts/forms.less
@@ -1,4 +1,11 @@
button,
html [type="button"],

This comment has been minimized.

@mfairchild365

mfairchild365 May 30, 2017

Member

why the explicit scoping to html?

@mfairchild365

mfairchild365 May 30, 2017

Member

why the explicit scoping to html?

This comment has been minimized.

@skoolbus39

skoolbus39 May 30, 2017

Member

I was restoring the removed styles directly from normalize.css. However, the explicit scoping to html is to prevent a WebKit audio/video control bug in Android 4 caused by -webkit-appearance: button. This fix is still part of normalize.css and still present in our framework, making the html unnecessary. I will remove.

@skoolbus39

skoolbus39 May 30, 2017

Member

I was restoring the removed styles directly from normalize.css. However, the explicit scoping to html is to prevent a WebKit audio/video control bug in Android 4 caused by -webkit-appearance: button. This fix is still part of normalize.css and still present in our framework, making the html unnecessary. I will remove.

@mfairchild365 mfairchild365 merged commit a6d6d04 into unl:develop May 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment