Update button and form styles #1482
Conversation
Fix variable used in background-color mixin (5.2 dark mode preview)
…preview # Conflicts: # package-lock.json
…preview # Conflicts: # package-lock.json
…s-forms # Conflicts: # package-lock.json
…s-forms # Conflicts: # package-lock.json
skoolbus39
changed the title
|
Probably an existing issue but buttons do not stack well. |
| .unl .dcf-btn-tertiary:active { | ||
| color: $color-active-light-mode; | ||
| .unl .dcf-btn:focus { | ||
| outline: 3px solid transparent; // https://sarahmhigley.com/writing/whcm-quick-tips/ |
There was a problem hiding this comment.
I'd prefer to keep this one to provide context.
| .unl .dcf-input-select:hover, // TODO: deprecate? | ||
| .unl .dcf-form select:hover { | ||
| box-shadow: 0 0 $length-em-3 fade-out($border-color-input-hover-light-mode,.25); | ||
| // box-shadow: 0 0 $length-em-3 fade-out($border-color-input-hover-light-mode,.25); |
| h1 { | ||
| margin: .67em 0; | ||
| } | ||
| // h1 { |
There was a problem hiding this comment.
The critical CSS is manually constructed from existing stylesheets. I commented rather than removed code so I could effectively toggle as many high-priority styles as possible until we got to ~13KB. Revisit in a separate issue?
| template { | ||
| display: none; | ||
| } | ||
| // dialog:not([open]), |
There was a problem hiding this comment.
Same as above comment
|
See comments. Note: css comments need to refer to associated scss. |
|
Button stacking is an existing issue. I've never found a one-size-fits-all fix for this issue, but we can revisit. |
|
Kudos, SonarCloud Quality Gate passed!
|
Don't merge until January.Safe to merge (pending review).