Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge dark mode preview branch into 5.3 #1550

Merged
merged 63 commits into from Oct 18, 2021
Merged

Merge dark mode preview branch into 5.3 #1550

merged 63 commits into from Oct 18, 2021

Conversation

skoolbus39
Copy link
Member

No description provided.

@skoolbus39
Enable dark mode preview in 5.3 CSS
901354c
@skoolbus39
Merge pull request #1496 from skoolbus39/5.3-dark-mode-preview
285e9e9 
Enable dark mode preview in 5.3 CSS
@skoolbus39
Merge branch '5.3' of github.com:unl/wdntemplates into 5.3-dark-mode-…
54c8174 
…preview
@skoolbus39
Fix inverse color in dark mode
fa2e504
@skoolbus39
Merge branch '5.3-dark-mode-preview' of github.com:unl/wdntemplates i…
f45cebe 
…nto 5.3-dark-mode-preview
@skoolbus39
Add dark-mode-specific color mixins/utilities
bfd81d3
@skoolbus39
Merge branch '5.3' of github.com:unl/wdntemplates into 5.3-dark-mode-…
f120749 
…preview
@skoolbus39
Adjust header link colors
b3d3f07 
Also, simplify CSS by using `dcf-site-group` to apply to both children – `dcf-site-affiliation` and `dcf-site-title`.
@skoolbus39
Update dark mode body color and background-color
d69ac75
@skoolbus39
Adjust tabs dark mode background color
766cdc8
@skoolbus39
Adjust input group add-on colors
573ca9e
@skoolbus39
Adjust input dark mode background color
e64bb90
@skoolbus39
Fix indent
d9cd391
@skoolbus39
Remove dark mode select arrow color override
a18cc05
@skoolbus39
Adjust card dark mode background color
f1aea34 
Also adjust comment indents
@skoolbus39
Update DCF and Node modules
41a8d06
@skoolbus39
Adjust background colors for dark mode
347a38a
@skoolbus39
Update theme color palette
4bfc9d9 
Add grays and light cerulean
@skoolbus39
Add form required color variable
674fbf9
@skoolbus39
Adjust anchor colors for dark mode
0755a9c
@skoolbus39
Adjust light text color for dark mode
f057eca
@skoolbus39
Update bookmarklet dark mode colors
1a23331
@skoolbus39
Merge branch '5.3' of github.com:unl/wdntemplates into 5.3-dark-mode-…
fae76ba 
…preview

# Conflicts:
#	package-lock.json
@skoolbus39
Add/remove utility classes to search
fa2bd99 
- Add margin utility to effectively remove the margin-bottom from the form label
- Remove the scarlet color class from the search button (It’s already scarlet in light mode and will automatically switch to cream in dark mode.)
@skoolbus39
Move color variables from body to colors-text
f811e4d
@skoolbus39
Adjust search input focus styles
f59f6a0
@skoolbus39
Merge branch '5.3' of github.com:unl/wdntemplates into 5.3-dark-mode-…
1129c9a 
…preview

# Conflicts:
#	wdn/templates_5.3/scss/generic/_generic.color-scheme.scss
@skoolbus39
Restore —bgdatepicker-dialog variable
b058410
@skoolbus39
Update —bg-color-datepicker-dialog-dark-mode
1e4bc29
@skoolbus39
Merge branch '5.3' of github.com:unl/wdntemplates into 5.3-dark-mode-…
242eb35 
…preview
@skoolbus39
Update dark mode toggle bookmarklet
1be963d
@skoolbus39
Update DCF and Node modules
f00d0d2
@skoolbus39
Merge branch '5.3' of github.com:unl/wdntemplates into 5.3-dark-mode-…
538c3d3 
…preview

# Conflicts:
#	package-lock.json
@skoolbus39
Update required indicator colors for dark mode
9744182
@skoolbus39
Adjust vertical alignment of required badge
25193a1
@skoolbus39
Update summary color
dbcb672
@skoolbus39
Merge branch '5.3' of github.com:unl/wdntemplates into 5.3-dark-mode-…
f9c1dbe 
…preview
@skoolbus39
Reorder CSS color variables
ffd4e03
@skoolbus39
Update DCF and Node modules
8a3e71d
@skoolbus39
Update form required label variables and usage
5daa7ba
@skoolbus39
Update badge comments
c589558
@skoolbus39
Remove btn-primary-inverse deprecated override
f7ecc2e
@skoolbus39
Update deprecated button styles
36fbf28
@skoolbus39
Update table stripe background colors
40bad8c
@skoolbus39
Update header button/link colors for dark mode
8687985
@skoolbus39
Remove color utility classes from CTA buttons
98d067e
@skoolbus39
Update gray dots background image for dark mode
6814132
@skoolbus39 skoolbus39 self-assigned this Oct 18, 2021
@jsturek
Copy link
Contributor

jsturek commented Oct 18, 2021

See sonarcloud bug. Looks like probably a typo.

@skoolbus39
Copy link
Member Author

It was indeed a typo – thanks to my broken command key.

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jsturek
jsturek approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@jsturek jsturek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I would run npm update dcf followed by npm install to ensure we have the latest dcf and the latest npm dependencies are included before merging.

@skoolbus39
Copy link
Member Author

I did again – just in case – and it's already up to date.

@skoolbus39 skoolbus39 merged commit ba96279 into 5.3 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericras ericras ericras approved these changes

@jsturek jsturek jsturek approved these changes

Assignees

@skoolbus39 skoolbus39

Labels
5.3 Dark Mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skoolbus39 @jsturek @ericras