Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for "project" query #69

Closed
ivarconr opened this issue Mar 9, 2021 · 0 comments
Closed

feat: add support for "project" query #69

ivarconr opened this issue Mar 9, 2021 · 0 comments
Projects
Unleash v4.0

Comments

@ivarconr
Copy link
Member

ivarconr commented Mar 9, 2021

The Unleash API client endpoint support query for specific project, to avoid having the SDK download all feature toggles like this:

http https://app.unleash-hosted.com/demo/api/client/features?project=solar 
Authorization:56907a2fa53c1d16101d509a10b78e36190b0f918d9f122d

Which will only return feature flags for projectId=solar.

This should be implemented by adding a new configuration to the unleash SDK to specify the "projectId" and of specified it should also be added to the feature-toggle query sent to Unleash API.
@ivarconr ivarconr added this to To do in Unleash v4.0 Mar 9, 2021
daveleek added a commit that referenced this issue Apr 28, 2021
@daveleek
add messagehandler stub for testing (#69)
0e731fa
daveleek added a commit that referenced this issue Apr 28, 2021
@daveleek
Add a failing unit test (#69)
2809b36
daveleek added a commit that referenced this issue Apr 28, 2021
@daveleek
Support project param in api client (#69)
fd3e016
daveleek added a commit that referenced this issue Apr 28, 2021
@daveleek
test the absence of query param (#69)
0570484
daveleek added a commit that referenced this issue Apr 28, 2021
@daveleek
add a projectId setting (#69)
5487e2d
@daveleek daveleek mentioned this issue Apr 28, 2021
Merged
11 tasks
@ivarconr ivarconr moved this from To do to In progress in Unleash v4.0 May 4, 2021
chriswk pushed a commit that referenced this issue Jun 16, 2021
Merge pull request #75 from Unleash/feature/supporting-project-query
4313a49 
feat: support project query parameter (#69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Unleash v4.0
In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivarconr @daveleek