You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Unleash Interface provides a function isEnabled(toggleName, context) with a default implementation.
In the default implementation, the context is silently dropped.
This is expected behavior i guess.
However, he DefaultUnleash implementation is missing an override for this function.
This leads to the behavior where DefaultUnleash.isEnabled(toggleName, context) silenlty drops the context.
Note that DefaultUnleash.isEnabled(toggleName, context, defaultValue) does not drop the context.
SDK information (language and version)
java client sdk 7.0.0
The text was updated successfully, but these errors were encountered:
hnicke
changed the title
DefaultUnleash does not override isEnabled(toggleName, context)
DefaultUnleash.isEnabled(toggleName, context) silently dropping context
Dec 16, 2022
Hi @hnicke the DefaultUnleash implementation seems to be working as expected (check #184 where I explained why is that). The interface is confusing nevertheless, so I'll bring this to @chriswk as an enhancement.
Thank you for looking into this.
My bad - you are right!
For some odd reason it didn't work for me last week.
I can confirm it is working as intended.
Sorry for the inconvenience.
Describe the bug
The
Unleash
Interface provides a functionisEnabled(toggleName, context)
with a default implementation.In the default implementation, the context is silently dropped.
This is expected behavior i guess.
However, he
DefaultUnleash
implementation is missing an override for this function.This leads to the behavior where
DefaultUnleash.isEnabled(toggleName, context)
silenlty drops the context.Note that
DefaultUnleash.isEnabled(toggleName, context, defaultValue)
does not drop the context.SDK information (language and version)
java client sdk 7.0.0
The text was updated successfully, but these errors were encountered: