Skip to content

Commit

Permalink
Revert "adding a way to build svg sprite (#226)" (#234)
Browse files Browse the repository at this point in the history
This reverts commit 64583c9.
  • Loading branch information
julien51 committed Sep 10, 2018
1 parent 9b9500c commit 1902645
Show file tree
Hide file tree
Showing 4 changed files with 3,622 additions and 4,164 deletions.
14 changes: 0 additions & 14 deletions unlock-app/README.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,3 @@
# SVG considerations

We try to use SVGs as much as possible when it comes to icons and logos.
However, in order to make loading these efficient, we combine them in a sprite which is then loaded
by the app and for which we pick the required subset.
We should consider adding that to the webpack build... but that would require ejecting the react application which comes with a lot of bagage and needs to be considered more thoroughly.
For now, when adding new icons, make sure you also generate the sprite:

` ./node_modules/svg-sprite/bin/svg-sprite.js --dest public/ public/images/icons/*.svg --defs`

(this will update the svg sprite file in `/public/defs/` )

------

## Default accounts for testing (set up thru ganach-cli)

Available Accounts
Expand Down

0 comments on commit 1902645

Please sign in to comment.