Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Uniswap v3 oracles #7746

Closed
julien51 opened this issue Nov 4, 2021 · 3 comments
Closed

Use Uniswap v3 oracles #7746

julien51 opened this issue Nov 4, 2021 · 3 comments
Labels
smart contract Smart contract related issue or task

Comments

@julien51
Copy link
Member

julien51 commented Nov 4, 2021

We currently rely on v2 pools to extract Oracle data about the price of tokens when computing the GDP. We also use that same v2 pool oracle when looking at the price of UDT when determining how many tokens need to be granted to the referrer.

Uniswap now has v3, that we could use directly.

This is not a high priority.

@julien51 julien51 added the smart contract Smart contract related issue or task label Nov 4, 2021
@julien51
Copy link
Member Author

This will be part of a larger change in Unlock that we hope to ship by year end 2022.

@hrik2001
Copy link

hrik2001 commented Aug 4, 2022

Hello @julien51! I am an intermediate solidity developer who has just got into the field.
I really like what you guys are working on and I should probably give this issue a try.
I believe I can work on a PR over time that fixes this ticket/issue (based on my understanding so far)
Do let me know if you want me to work on this!

@clemsos
Copy link
Member

clemsos commented Sep 15, 2022

Closed in favor of #9554

@clemsos clemsos closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smart contract Smart contract related issue or task
Projects
None yet
Development

No branches or pull requests

3 participants