feat(governance): protocol upgrade Unlock v13 and PublicLock v14 on Sepolia #13190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemsos
commented
Jan 10, 2024
| @@ -5347,7 +5347,7 @@ pragma solidity ^0.8.21; | |||
| * Every ERC-721 compliant contract must implement the ERC165 interface. | |||
| * https://eips.ethereum.org/EIPS/eip-721 | |||
| */ | |||
| contract PublicLockV14 is | |||
| contract PublicLock is | |||
There was a problem hiding this comment.
this is actually needed for consistency across version. All contracts are called Unlock or PublicLock, only the name of the file differs. That is the pattern that is used across the scripts. I changed it before but better to not number the contract name actually
There was a problem hiding this comment.
I actually moved this to its own PR as more changes are required (e.g. re packaging the bytecode) #13197
clemsos
commented
Jan 10, 2024
Comment on lines
-10
to
-12
| const Safe = require('@safe-global/safe-core-sdk').default | ||
| const SafeServiceClient = require('@safe-global/safe-service-client').default | ||
| const EthersAdapter = require('@safe-global/safe-ethers-lib').default |
There was a problem hiding this comment.
these libs ave been deprec by Safe team
6 tasks
…into deploy-sepolia
julien51
approved these changes
Jan 10, 2024
| }) | ||
| } | ||
| const transactionId = await submitTx(txArgs) | ||
| console.log(transactionId) |
| @@ -48,7 +48,7 @@ export const sepolia: NetworkConfig = { | |||
| isTestNetwork: true, | |||
| keyManagerAddress: '0x338b1f296217485bf4df6CE9f93ab4C73F72b57D', | |||
| maxFreeClaimCost: 1000, | |||
| multisig: '', // SAFE does not support Sepolia as of October 11th 2023 | |||
|
UnlockSwapBurner deployed at 0xc9577b38ADA2B1b251EE99e54cC399027d547B68 |
Nice! |
|
remaining tasks for sepolia
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the manifest files for deployments of Unlock v13 and PublicLock v14 on Sepolia, as well as a few fixes in the deployment / upgrade scripts
Issues
Fixes #
Refs #
Checklist:
Release Note Draft Snippet