-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(unlock-js): add Unlock v13 and PublicLock v14 support #13196
Conversation
'v4', | ||
'v6', | ||
'v7', | ||
'v8', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should consider cleaning up these older versions... wdyt?
'v11', | ||
'v12', | ||
'v13', | ||
] | ||
const publicLockVersions = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here. I'd sayd anything that has not seen any activity in 2 years can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes will do in another PR
export default { | ||
...v13, | ||
version: 'v14', | ||
PublicLock: abis.PublicLock.v14, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No function change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we added a setExpirationKey
but I wasn't sure we'll need it in unlockjs rn
Description
This adds support Unlock v13 and PublicLock v14 to unlock-js
Issues
Fixes #
Refs #
Checklist:
Release Note Draft Snippet