Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(unlock-app): No slug #13206

Merged
merged 4 commits into from
Jan 16, 2024
Merged

cleanup(unlock-app): No slug #13206

merged 4 commits into from
Jan 16, 2024

Conversation

julien51
Copy link
Member

Description

Users should not have to set slugs themselves so we're removing this from the fields to set in metadata.

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Jan 15, 2024
@julien51 julien51 requested a review from clemsos January 15, 2024 22:29
@julien51 julien51 merged commit a32413e into master Jan 16, 2024
12 checks passed
@julien51 julien51 deleted the no-slug branch January 16, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant