Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(governance): tools to safely transfer contract ownership #13218

Merged
merged 10 commits into from
Jan 24, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Jan 18, 2024

Description

Improvements on our CLI task to transfer ownership with multisig support, some warnings, etc

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Jan 18, 2024
@clemsos clemsos requested a review from julien51 January 18, 2024 14:10
@@ -5,6 +5,9 @@ require('@nomicfoundation/hardhat-ethers')
require('@nomicfoundation/hardhat-verify')
require('@openzeppelin/hardhat-upgrades')

const tdly = require('@tenderly/hardhat-tenderly')
tdly.setup()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to merge/ rebase #13220

accounts: process.env.DEPLOYER_PRIVATE_KEY
? [
{
privateKey: process.env.DEPLOYER_PRIVATE_KEY,
Copy link
Member Author

@clemsos clemsos Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support setting private key on local forks

@clemsos clemsos merged commit 78a5fc9 into master Jan 24, 2024
12 checks passed
@clemsos clemsos deleted the transfer-contract-ownership-task branch January 24, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants