Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smart-contracts): remove limitation on max number of keys #13223

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

julien51
Copy link
Member

Description

We should not prevent a lock manager from setting a value lower than supply.
In practice we already allow for that state (number of keys > maxKeysForSale) because we let lock manager airdrop keys to users even when we are above the limit!

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@julien51 julien51 requested a review from clemsos January 19, 2024 21:45
@cla-bot cla-bot bot added the cla-signed label Jan 19, 2024
@julien51 julien51 merged commit b9c1f0f into master Jan 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants