Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smart-contracts): fix upgrades test by using qualified path #13234

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Jan 25, 2024

Description

This fixes the way ethersjs factories are created in upgrade tests - bug introduced in 04be524

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Jan 25, 2024
@clemsos clemsos requested a review from julien51 January 25, 2024 09:16
@clemsos clemsos merged commit 3dd17e0 into master Jan 25, 2024
12 checks passed
@clemsos clemsos deleted the fix-upgrade-tests-qualified-path branch January 25, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants