Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locksmith, unlock-app, core): dry constants #13237

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

julien51
Copy link
Member

Description

A very modest cleanup to move some constants to the core package for clarity.

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@julien51 julien51 requested a review from clemsos January 25, 2024 15:59
@cla-bot cla-bot bot added the cla-signed label Jan 25, 2024
@julien51 julien51 requested review from searchableguy and clemsos and removed request for clemsos January 25, 2024 15:59
@julien51 julien51 merged commit 953de37 into master Jan 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant