Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(unlock-app): using checkout config in all cases for events #13299

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Feb 1, 2024

Description

Simplifying code by having a single checkout config in all cases for events and no hard coded values (outside of the default, used to create the event)

Issues

Fixes #13245

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Feb 1, 2024
@julien51 julien51 merged commit 21cfaf2 into master Feb 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: use the metadataInputs by default
1 participant