Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unlock-app): adding OG for events #13331

Merged
merged 2 commits into from
Feb 9, 2024
Merged

feat(unlock-app): adding OG for events #13331

merged 2 commits into from
Feb 9, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Feb 8, 2024

Description

Adding OG image rendering for events (stolen from locksmith).
Also adding 404 when the event does not exist (#13325)

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@@ -0,0 +1,16 @@
export const metadata = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was autogen. I probably need to update a bit later!

{ params }: { params: { slug: string } }
) {
// Loading fonts from static assets
const inter400 = await fetch(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find a way to get fonts "locally" so we're downloading them from the public folder... which is kind of weird.

@julien51 julien51 merged commit 4ff1ac2 into master Feb 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant