Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unlock-protocol-com,paywall): bump @types/next to latest #13342

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Feb 14, 2024

Description

For some reasons, master build starting to break with the following error. This fixes it

./src/components/helpers/Link.tsx:11:8
Type error: 'NextLink' cannot be used as a JSX component.
  Its return type 'ReactNode' is not a valid JSX element.
    Type 'string' is not assignable to type 'Element'.

   9 |   if (isInternalLink) {
  10 |     return (
> 11 |       <NextLink href={href} legacyBehavior>
     |        ^
  12 |         <a {...rest} />
  13 |       </NextLink>
  14 |     )

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clemsos clemsos merged commit 310b5df into master Feb 14, 2024
12 checks passed
@clemsos clemsos deleted the fix-types-next branch February 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants