Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(paywall): loadCheckoutModal now resolves when the modal is closed #13423

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Mar 7, 2024

Description

By resolving we let 3rd party applications handle things on their own when the modal is closed.
This is requested by the team at Coinage/Best Dish Ever.

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Mar 7, 2024
@julien51 julien51 merged commit f4741d0 into master Mar 7, 2024
12 checks passed
julien51 added a commit that referenced this pull request Mar 7, 2024
#13423)

loadCheckoutModal now resolves when the modal is closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant