Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unlock-app): fixing the password setting flow #13424

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix(unlock-app): fixing the password setting flow #13424

merged 2 commits into from
Mar 7, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Mar 7, 2024 •
edited

Description

The form to set passwords was broken.
That fixed it!
thanks @pavvann !

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Mar 7, 2024
@julien51 julien51 merged commit 4e30242 into master Mar 7, 2024
12 checks passed
@julien51 julien51 deleted the password-hook-debug branch March 7, 2024 20:58
julien51 added a commit that referenced this pull request Mar 7, 2024
@julien51
fix(unlock-app): fixing the password setting flow (#13424)
f9fa6e4 
* fix(unlock-app): fixing the password setting flow

* typescript fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@julien51