Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unlock-app): waits even in optimisitic checkout #13455

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

julien51
Copy link
Member

Description

We are waiting for the tx to complete and updating the UX, even if the user is not required to wait and they can just close the modal.

Issues

Fixes ##13452
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Mar 12, 2024
@julien51 julien51 requested review from clemsos and searchableguy and removed request for clemsos March 12, 2024 16:47
@julien51 julien51 changed the title waits even in optimisitic checkout feat(unlock-app): waits even in optimisitic checkout Mar 12, 2024
@julien51 julien51 merged commit 6d7a9f5 into master Mar 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant