Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unlock-app): multi password hook #13503

Merged
merged 11 commits into from
Mar 24, 2024
Merged

feat(unlock-app): multi password hook #13503

merged 11 commits into from
Mar 24, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Mar 21, 2024

Description

The current password hook only supports "single" passwords per lock.
With this new version a lock manager can set multiple different passwords, with a cap for each of them so that lock manager can "invite" different groups with different passwords.

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Mar 21, 2024
@julien51 julien51 requested a review from clemsos March 22, 2024 12:46
@julien51 julien51 changed the title Multi password hook feat(unlock-app): multi password hook Mar 22, 2024
@julien51 julien51 merged commit 9b72f27 into master Mar 24, 2024
13 checks passed
@julien51 julien51 deleted the multi-password-hook branch March 24, 2024 16:23
blahkheart pushed a commit to blahkheart/unlock that referenced this pull request Mar 26, 2024
* wip

* locksmith

* adidng support for password hook with cap

* using the hook for checkout

* refactored the password hook UI in checkout

* adding changelog
blahkheart pushed a commit to blahkheart/unlock that referenced this pull request Mar 28, 2024
* wip

* locksmith

* adidng support for password hook with cap

* using the hook for checkout

* refactored the password hook UI in checkout

* adding changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant