Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unlock-app): better loading UI for the Wallet-less registration block #13585

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Apr 1, 2024

Description

Increasing the side of the loader, but also its contrast. This will affect all Placeholders in the app!

Screenshot 2024-04-01 at 5 11 48 PM

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Apr 1, 2024
@julien51 julien51 requested a review from SVell April 1, 2024 21:12
Copy link
Contributor

@SVell SVell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@julien51 julien51 merged commit aee2b49 into master Apr 2, 2024
12 checks passed
@julien51 julien51 deleted the event-registration-loader branch April 2, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants