Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unlock-app): Changed frame description #13609

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

SVell
Copy link
Contributor

@SVell SVell commented Apr 5, 2024

Description

Changed frame description

Issues

Fixes #13544
Refs #13544

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

image
image

@cla-bot cla-bot bot added the cla-signed label Apr 5, 2024
@SVell
Copy link
Contributor Author

SVell commented Apr 5, 2024

Do not think we should make it 1:1. Let's leave as is for visual clarity and no size changes

@SVell SVell marked this pull request as ready for review April 5, 2024 15:25
@@ -12,10 +12,34 @@ export const Description = ({
previousFrame: any
state: any
}) => {
const removeMd = require('remove-markdown')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this at the top of the file! Also, please use import :)

Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think we could apply that to the OpenGraph previews (description).
Can you do it at the same time please?

Screenshot 2024-04-05 at 2 09 41 PM

@SVell
Copy link
Contributor Author

SVell commented Apr 6, 2024

image

@SVell SVell requested a review from julien51 April 6, 2024 17:19
@julien51 julien51 merged commit 307371a into unlock-protocol:master Apr 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event [description] frame formatting
2 participants