Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locksmith): Removed the old coinbase pricing API #13611

Merged
merged 10 commits into from
Apr 9, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Apr 6, 2024

Description

Simplifying some code!

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@@ -66,7 +66,7 @@ export const linea: NetworkConfig = {
name: 'Linea',

nativeCurrency: {
coingecko: 'linea-eth',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not exist on coingecko!

@@ -28,7 +28,7 @@ export const zksync: NetworkConfig = {
multisig: '0xFa5592CE9C52FA5214ccEa10cB72Faa88eC80a3c',
name: 'zkSync Era',
nativeCurrency: {
coingecko: 'zksync-eth',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not exist on coingecko!

@julien51 julien51 requested a review from SVell April 6, 2024 02:07
@julien51 julien51 changed the title refactor(locksmiht): Removed the old coinbase pricing API refactor(locksmith): Removed the old coinbase pricing API Apr 6, 2024
@julien51 julien51 merged commit db6560c into master Apr 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants