feature: ask organizers to setup the reply to email when they create the event #13621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien51
commented
Apr 11, 2024
| @@ -1,7 +1,7 @@ | |||
| import { RequestHandler } from 'express' | |||
| import { | |||
| getEventBySlug, | |||
| getEventDataForLock, | |||
julien51
commented
Apr 11, 2024
| @@ -36,7 +37,31 @@ const getEventDate = ( | |||
| return null | |||
| } | |||
|
|
|||
| export const getEventDataForLock = async ( | |||
| export const getEventForLock = async ( | |||
There was a problem hiding this comment.
This is extracted so we can re-use.
julien51
commented
Apr 11, 2024
| const res = settings || DEFAULT_LOCK_SETTINGS | ||
| const lockSettings = settings || DEFAULT_LOCK_SETTINGS | ||
|
|
||
| const eventDetails = await getEventForLock(lockAddress, network) |
There was a problem hiding this comment.
Getting the event's settings for replyTo and emailSender and prioritizing these.
julien51
commented
Apr 11, 2024
| @@ -363,30 +357,6 @@ export const EventDetails = ({ | |||
| Tools for you, the event organizer | |||
| </span> | |||
| <div className="grid gap-4"> | |||
| <Card className="grid grid-cols-1 gap-2 md:items-center md:grid-cols-3"> | |||
There was a problem hiding this comment.
We moved this to the settings.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We now require organizers to submit their email address and name when they are preparing a new event.
Issues
Fixes #13188
Checklist:
Release Note Draft Snippet