Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui, unlock-app): adding a checkbox element #13622

Merged
merged 5 commits into from
Apr 12, 2024
Merged

feat(ui, unlock-app): adding a checkbox element #13622

merged 5 commits into from
Apr 12, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Apr 11, 2024 •
edited

Description

Adding a checkbox component to the UI library!

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Apr 11, 2024
@julien51
Copy link
Member Author

Regular:
Screenshot 2024-04-11 at 6 49 41 PM

Large, with error:
Screenshot 2024-04-11 at 6 49 30 PM

SVell

This comment was marked as outdated.

Sign in to view

@julien51 julien51 merged commit a679643 into master Apr 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SVell SVell SVell approved these changes

@searchableguy searchableguy Awaiting requested review from searchableguy

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julien51 @SVell