Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(smart-contracts): advanced token URI hook #13633

Merged
merged 7 commits into from
Apr 17, 2024
Merged

Conversation

julien51
Copy link
Member

Description

For FarCon, our friends at Icreabreaker.xyz are using their own backend fo the metadata, but they need to have the owner's address in the URL, rather than just the token id.
We're adding a custom onTokenURI hook that provides an advanced setup.

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Apr 15, 2024
@julien51 julien51 requested review from clemsos and SVell April 15, 2024 22:32
@@ -0,0 +1,79 @@
const { expect } = require('chai')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use import?

@julien51 julien51 merged commit 88b47a1 into master Apr 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants