Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unlock-app): Event UI improvements #13653

Merged
merged 7 commits into from
Apr 19, 2024
Merged

feat(unlock-app): Event UI improvements #13653

merged 7 commits into from
Apr 19, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Apr 19, 2024 •
edited

Description

  • Not asking for email twice when using an Unlock account
  • Fixed the button to update the header image
  • Changed mention of NFT to pass when applicable
  • Requiring an image when setting up an event

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Apr 19, 2024
@julien51 julien51 merged commit e3c0ba9 into master Apr 19, 2024
12 checks passed
julien51 added a commit that referenced this pull request Apr 22, 2024
@julien51
feat(unlock-app): Event UI improvements (#13653)
7da9661 
* removed QR code

* wip

* fixing cover image

* not asking email twice anymore

* cleanup

* fixing typescript and eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@julien51