Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): fix Integration tests #13772

Merged
merged 29 commits into from May 6, 2024
Merged

feat(tests): fix Integration tests #13772

merged 29 commits into from May 6, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented May 2, 2024

Description

This PR brings back integration tests. It needs to be rebased once #13657 is merged

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label May 2, 2024
@clemsos clemsos requested a review from julien51 May 2, 2024 22:42
@@ -1,5 +1,9 @@
# CHANGELOG

### 0.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the version in the package.json file too :)

Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits/changes and then LG!

@clemsos
Copy link
Member Author

clemsos commented May 6, 2024

Need to merge #13778 before this one

@clemsos
Copy link
Member Author

clemsos commented May 6, 2024

Maybe good to make sure we are using latest versions of the contracts #13498

@clemsos clemsos merged commit 22a0627 into master May 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants