Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unlock-app): more paywall fixes #14033

Merged
merged 4 commits into from
Jun 12, 2024
Merged

fix(unlock-app): more paywall fixes #14033

merged 4 commits into from
Jun 12, 2024

Conversation

julien51
Copy link
Member

Description

Another round of fixes fo the paywall.

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Jun 11, 2024
@julien51 julien51 requested review from SVell and clemsos June 11, 2024 16:56
@julien51 julien51 marked this pull request as ready for review June 11, 2024 16:56
SVell
SVell approved these changes Jun 12, 2024
View reviewed changes
unlock-app/src/utils/iframe.ts Outdated
@@ -0,0 +1,4 @@
export const isInIframe = () => {
console.log('isInIframe')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this log here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops! Indeed. cleaned up!

@julien51 julien51 merged commit f8a472d into master Jun 12, 2024
7 checks passed
@julien51 julien51 mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SVell SVell SVell approved these changes

@clemsos clemsos Awaiting requested review from clemsos

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julien51 @SVell