feat(unlock-app): Decent for swaps #14043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien51
commented
Jun 13, 2024
| @@ -165,27 +164,15 @@ export function Payment({ checkoutService }: Props) { | |||
|
|
|||
| const canAfford = balance?.isGasPayable && balance?.isPayable | |||
|
|
|||
| const { data: uniswapRoutes, isInitialLoading: isUniswapRoutesLoading } = | |||
| useUniswapRoutes({ | |||
There was a problem hiding this comment.
I will clean up on a different PR.
julien51
commented
Jun 13, 2024
| userTokenBalance: string | ||
| } | ||
|
|
||
| // TheBox returns BigInts as strings with a trailing 'n' |
There was a problem hiding this comment.
looking into it, yes its a real issue when parsing serialized values...
clemsos
reviewed
Jun 14, 2024
| @@ -425,22 +365,28 @@ export function Payment({ checkoutService }: Props) { | |||
| > | |||
| <div className="flex justify-between w-full"> | |||
| <h3 className="font-bold"> | |||
| Pay with {route.symbol} on {route.networkName} | |||
| Pay with {route.tokenPayment.symbol} on{' '} | |||
There was a problem hiding this comment.
that throws. an error when the lock is priced in native token. Added a fix
There was a problem hiding this comment.
ha! Good catch I will look at this gain.
clemsos
approved these changes
Jun 14, 2024
This was referenced Jun 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until now we used Decent for the "crosschain purchase" scenario where the transaction would be sent from different network, but only paid on this network's native currency.
Since Uniswap broke their libraries, we are now also using Decent for "swap" scenario where we now have the following supported flows:
Issues
Fixes #
Refs #
Checklist:
Release Note Draft Snippet