Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smart-contracts): rollback @oz/upgrades-core to 1.33.1 #14059

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Jun 17, 2024

Description

The new version of OZ upgrades checks for internal function in storage layout. The OZ upgradeable contracts package currently has an issue that leads the test suite to crash. Instead of this disabling OZ checks with unsafe-allow, we rollback to a previous version until a fix is released

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2024
@clemsos clemsos requested a review from julien51 June 17, 2024 13:35
@clemsos clemsos changed the title fix(smart-contracts): disallow internal function check in tests for UDT v3 fix(smart-contracts): rollback @oz/upgrades-core to 1.33.1 Jun 17, 2024
@clemsos clemsos changed the title fix(smart-contracts): rollback @oz/upgrades-core to 1.33.1 fix(smart-contracts): rollback @oz/upgrades-core to 1.33.1 Jun 17, 2024
@clemsos clemsos merged commit d2f46e0 into master Jun 17, 2024
1 check passed
@clemsos clemsos deleted the fix-oz-upgrades-udt-bug branch June 17, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants