Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(packages/ui): Fixed Select more options #14061

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix(packages/ui): Fixed Select more options #14061

merged 2 commits into from
Jun 18, 2024

Conversation

SVell
Copy link
Contributor

@SVell SVell commented Jun 17, 2024

Description

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2024
@SVell SVell marked this pull request as ready for review June 17, 2024 21:00
@SVell SVell marked this pull request as draft June 17, 2024 21:03
@SVell SVell marked this pull request as ready for review June 17, 2024 21:26
julien51
julien51 reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this tested this time?

@SVell
Copy link
Contributor Author

SVell commented Jun 17, 2024

https://www.loom.com/share/3a6b83484ded46aa921dc945ccf931f0?sid=376c62a8-4dbd-4be0-a209-ef28ec6b1884

@julien51 julien51 merged commit 2c21135 into master Jun 18, 2024
12 checks passed
@julien51 julien51 deleted the show-all-fix branch June 18, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien51 julien51 julien51 left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SVell @julien51