Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unlock-app): Allow editing metadata inputs #14069

Merged
merged 1 commit into from
Jun 19, 2024
Merged

feat(unlock-app): Allow editing metadata inputs #14069

merged 1 commit into from
Jun 19, 2024

Conversation

iMac7
Copy link
Contributor

@iMac7 iMac7 commented Jun 19, 2024

Description

Enables users to edit metadata inputs

https://www.loom.com/share/6f012c3d13034f6b8f7325c4d641ca92?sid=21fb238e-985c-46bb-ad00-ff55e14aee0b

Issues

Fixes #13690

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Jun 19, 2024
@iMac7 iMac7 changed the title initial commit feat(unlock-app): Allow editing metadata inputs Jun 19, 2024
@julien51 julien51 self-requested a review June 19, 2024 13:11
@julien51
Copy link
Member

Looking good!

julien51
julien51 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julien51
Copy link
Member

Please add your wallet address on the issue itself and I will send the payment ASAP!

@julien51 julien51 merged commit b3d118c into unlock-protocol:master Jun 19, 2024
9 checks passed
@iMac7
Copy link
Contributor Author

iMac7 commented Jun 19, 2024

Please add your wallet address on the issue itself and I will send the payment ASAP!

added :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien51 julien51 julien51 approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow edits for metadata inputs
2 participants
@iMac7 @julien51