Preserve timestamps and permissions #179
Conversation
The `--preserve-timestamp` flag can now be used to copy the timestamp of the original file to the converted file. This partly fix unoconv#31.
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Is there really a need for that?
There was a problem hiding this comment.
No, the modification is compatible with both Python 2.x and Python 3.x. I just tested with Python 3.x last.
There was a problem hiding this comment.
@vincentbernat Very nice! Can you put back original shebang? Because it's not tested well on python 3 to do such risky changes and there is not needs for that PR.
And I will be ready to merge it!
|
👍 |
dagwieers
force-pushed
the
master
branch
3 times, most recently
from
3a5dc40
to
bf7097d
Compare
And change its name to `--preserve`. This is mostly what is requested in unoconv#31.
vincentbernat
force-pushed
the
feature/preserve-timestamp
branch
from
d2ac4b8
to
0cc8c70
Compare
|
OK, just updated! |
|
Great! I will handle it! |
|
@dagwieers please, take a look for this update also. It's simple, but sometimes can be useful. |
|
Oh my, I didn't see this PR at all. This is definitely something we needed, and I like the implementation as well ! And to be honest, I think this should be the default (expected) behavior. Or are there any use-cases where we don't want to do this ? (Security-wise I'd expect the permissions to be exactly as they were and not use umask at all) The only reason for not doing this by default to me is the fact that other tools also make this optional. And that is a good reason too. PS A short option would be convenient as well if this is not the default behavior, unfortunately -p is already taken (I wish it wasn't though, --port would have sufficed) |
Preserve timestamps and permissions
|
Thanks a lot ! |
Add a
--preserveoption to keep both timestamps and permissions. This closes #31, except for the owner part. I don't think that preserving the owner is really important as it is only possible while being root and this should not be really a use case for unoconv.I have only tested with Python3 has I don't have UNO binding for Python 2 anymore but the code should be compatible with Python 2. Please test if you can.