Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command line option to specify import filter name #343

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

MartijnVdS
Copy link
Contributor

With this new command line option, "-I" or "--import-filter-name", it's
possible to specify the short name of an import filter (in the same style
as "-f"/"--format")

This is useful when converting files without extensions or from stdin
because type detection for text-based file formats can sometimes fail in
those cases, leading to "parser error : Document is empty" error messages.

Example use:
unoconv --stdin --stdout -I txt -f pdf < my_textfile.txt > output.pdf

@MartijnVdS
Copy link
Contributor Author

The CI failure seems to be because LibreOffice_4.1.6.1_Linux_x86-64_deb.tar.gz can't be found

Copy link
Member

@regebro regebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Can you rebase from master and see if the integration checks passes?

@MartijnVdS
Copy link
Contributor Author

The branch is already up to date with master.

Is there a way to re-run the integration tests manually?

With this new command line option, "-I" or "--import-filter-name", it's
possible to specify the short name of an import filter (in the same style
as "-f"/"--format")

This is useful when converting files without extensions or from stdin
because type detection for text-based file formats can sometimes fail in
those cases, leading to "parser error : Document is empty" error messages.

Example use:
  unoconv --stdin --stdout -I txt -f pdf < my_textfile.txt > output.pdf
@regebro
Copy link
Member

regebro commented Oct 12, 2017

Not by me. You could try doing a git commit --amend, and then git push --force. That recreates your commit and Travis should rerun, you can try that if you want.

Otherwise I'll try to test this manually when I get time.

@MartijnVdS
Copy link
Contributor Author

I did the --amend trick this morning, but it seems to have failed again on one version.

@regebro regebro added this to the Release 0.8 milestone Oct 12, 2017
@regebro
Copy link
Member

regebro commented Oct 12, 2017

Yeah, that's OK, we'll drop the support for that version.

@regebro regebro merged commit b752274 into unoconv:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants