Endless recursion fix for windows... #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows OpenOffice/LibreOffice are two python binaries within the basepath:
(1) C:\Program Files (x86)\OpenOffice.org 3\program\python.exe
(2) C:\Program Files (x86)\OpenOffice.org 3\Basis\program\python-core-2.6.1\bin\python.exe
find_offices() always finds (1) as office python, while unopath is always set to
'C:\Program Files (x86)\OpenOffice.org 3\Basis\program'.
Thus "sys.executable.startswith(of.*uno*path)" is always "False", which leads to an endless
(recursive) restart in python_switch() (at least on Windows).
To fix this call only python_switch() as long no python binary from within *base*path
is executed.
--vpa
ghost
assigned 
dagwieers
added a commit
that referenced
this pull request
Jul 30, 2012
Endless recursion fix for windows...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows OpenOffice/LibreOffice are two python binaries within the basepath:
(1) C:\Program Files (x86)\OpenOffice.org 3\program\python.exe
(2) C:\Program Files (x86)\OpenOffice.org 3\Basis\program\python-core-2.6.1\bin\python.exe
find_offices() always finds (1) as office python, while unopath is always set to
'C:\Program Files (x86)\OpenOffice.org 3\Basis\program'.
Thus "sys.executable.startswith(of._uno_path)" is always "False", which leads to an endless
(recursive) restart in python_switch() (at least on Windows).
To fix this call only python_switch() as long no python binary from within _base_path
is executed.
--vpa