Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ring-offset-0 missing unit #3196

Closed
4 tasks done
DSeeLP opened this issue Oct 3, 2023 · 6 comments · Fixed by #3271
Closed
4 tasks done

ring-offset-0 missing unit #3196

DSeeLP opened this issue Oct 3, 2023 · 6 comments · Fixed by #3271
Assignees
Labels
bug Something isn't working preset-mini

Comments

@DSeeLP
Copy link

DSeeLP commented Oct 3, 2023

UnoCSS version

0.55.7

Describe the bug

ring-offest-0 is missing unit in generated css and declaring a unit explicitly doesn't work either ring-offset-0px.

CSS output from playground from reproduction:

.ring-offset-0,
.ring-offset-0px,
.ring-offset-0rem{--un-ring-offset-width:0;}

Reproduction

https://unocss.dev/play/?html=DwEwlgbgBAFgtAMwK4BsVQC4FMAeG4DGWAdtgE5QIq5QDOW1B%2BxA9sVlAIZoBcGZnYrTAYwbOABYADFKgAjAOZw5KTgQDWAPgBQUKKEiVqOI7kIt0IrAFtahEuSgArJLVEIAnvdJYKAd0RUdAVOAAc4AEYJHT09A2gCVVpaAF4AIkU4BQEPKDIwYiUJPIKlMiwQEsK4FgQEenwpNJjYvQB5OoaoKV1Y4AB6cAgWuKGoRM5k9Mzszlz86uKFsoqqpVr6rEbQnGbe1o7NjG6d-f1ByBH9MYmpjKVZ%2BdLJNbhyyuWazq24KXLrPatdrfY5-GxnAZDK7xcZJVL3LI5V5LZ7vV4bBqRHaAoGHLoRU6tSGXCE3OHTB5Iz4o6poz4Yn5SAB0ACYAKz-HEHEHdVkc8FEi7DXrE4WizRAA&config=PTAEFMGcBsEsDsAuBaAJrSBDARtcz5wAPFOQ0eAe2QCcpEbYBjRcVZWAWwAdKbFIAKC69%2BoAN6DQoVOABmCcAGFK8BQHMANFNDc6kcIgCCiBrGwBXRLDkBPbdL1RDASSarID3fsMBVKtoAvqByNJScoADkFlRMkJCRgoLEoogy8pgW0GmyCoQqarDqABSS0jRZUABcoADaOtK1kUwWkIjhtJWRmhKg7tB8NZF0qJGggQC6XlM6kAAWfIgtAjVl0lEtbR3zi8uRQ6wkyNDqoIcofJjw6uCgCwBu4DRV58ismNDdOoFeTgYrdQa3mciH8lGKAEovI4fMZTIxLNY7JDocD-m4PKUgdJIEwPuAagBGAB0ACZUdImKh4EM5qZuJAqiAoJxifNgF91uMoToZoEIYIgA&css=PQKgBA6gTglgLgUzAYwK4Gc4HsC2YDCAyoWABYJQIA0YAhgHYAmYcUD6AZllDhWOqgAOg7nAB0YAGLcwCAB60cggDYIAXGBDAAUKDBi0mXGADe2sGC704AWgDuCGAHNScDQFYADJ4Dc5sAACtMLKAJ5gggCMLPK2ABR2pPBIcsoAlH4WAEa0yADWTlBYqEw2yFjK3Bpw5LxxAOTllVDoYpSMYgAs3vUZ2gC%2BmsBAA&options=N4XyA

System Info

No response

Validations

@DSeeLP
Copy link
Author

DSeeLP commented Oct 3, 2023

I'm using this rule as a workaround:

["ring-offset-0", {
    "--un-ring-offset-width": "0px"
}],

@Simon-He95
Copy link
Contributor

I'm using this rule as a workaround:

["ring-offset-0", {
    "--un-ring-offset-width": "0px"
}],

this is intentional。
related:#2153

@henrikvilhelmberglund
Copy link
Contributor

I'm using this rule as a workaround:

["ring-offset-0", {
    "--un-ring-offset-width": "0px"
}],

this is intentional。 related:#2153

For inset maybe but ring-offset-0 should give 0px for Tailwind alignment. It also generally seems strange that setting the offset to 0 should remove the ring itself instead of just setting the offset to 0.

Also you can use ring-offset-[0px] if you want another workaround.

@zyyv zyyv closed this as completed Oct 23, 2023
@henrikvilhelmberglund
Copy link
Contributor

@zyyv zyyv reopened this Oct 24, 2023
@zyyv zyyv self-assigned this Oct 24, 2023
@zyyv zyyv added bug Something isn't working preset-mini labels Oct 24, 2023
@Simon-He95
Copy link
Contributor

The corresponding display effect on tailwindcss
https://play.tailwindcss.com/pxoBNZhfsx

@henrikvilhelmberglund
Copy link
Contributor

henrikvilhelmberglund commented Oct 24, 2023

Apparently in Tailwind it's underline-offset-0 instead of decoration-offset-0.
https://play.tailwindcss.com/m8W2y5nFm4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preset-mini
Projects
None yet
4 participants