-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vite): detect app behind frontend server #408
Conversation
✔️ Deploy Preview for ecstatic-mestorf-2e8afd ready! 🔨 Explore the source changes: 5e03185 🔍 Inspect the deploy log: https://app.netlify.com/sites/ecstatic-mestorf-2e8afd/deploys/61d854e95064fb0008d357fc 😎 Browse the preview: https://deploy-preview-408--ecstatic-mestorf-2e8afd.netlify.app |
Could we somehow detect automatically (from vite config or client runtime) without introduce a separate option for that? |
I'm editing the file to inline the configuration using the vite types... |
The problem is we don't know if the app is behind a front end, so, how we can detect that without any hint from the use land? |
For example, I use apache + dev server, the vite app cannot infer if apache is in front of it |
we can include always the |
changing logic to include it on the client side |
@chuoke with the new approach, you don't need to add anything on the plugin configuration, we added the logic to detect automatically on the client side |
# Conflicts: # packages/vite/README.md
Uh, I've been watching (waiting) this, wondering what's going on right now? Are you preparing for a better plan? Can anyone reveal some plans? 呃,我一直在关注(等待)这个,不知道现在是怎么情况?是在准备更好的方案吗?谁能透露一些计划吗? |
This PR allows enable the
UnoCSS
plugin forglobal
model when the Vite application is behind a frontend server, also on dev mode: for example usingPHP + Laravel + Inertia
.I added also a custom server configuration, I don't know if this makes sense, but @chuoke request it on the disccusion linked bellow.
For context see: