Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing preset-wind to typescript config file #659

Merged
merged 2 commits into from
Feb 27, 2022

Conversation

userquin
Copy link
Member

This PR fix the build problem on windows

@userquin userquin requested a review from antfu as a code owner February 27, 2022 12:38
@netlify
Copy link

netlify bot commented Feb 27, 2022

✔️ Deploy Preview for unocss ready!

🔨 Explore the source changes: 556d9db

🔍 Inspect the deploy log: https://app.netlify.com/sites/unocss/deploys/621ba3554725390008c4f279

😎 Browse the preview: https://deploy-preview-659--unocss.netlify.app

@userquin
Copy link
Member Author

it is also reported on jiti (unjs/jiti#49) and some similar issue on unbuild (unjs/unbuild#38)

@userquin
Copy link
Member Author

userquin commented Feb 27, 2022

it seems removing respectExternal from unbuild::rollup.mjs just works: rollupOptions.plugins.push(dts(/*{ respectExternal: true }*/))

imagen

@antfu antfu merged commit fa6e477 into main Feb 27, 2022
@antfu antfu deleted the userquin/fix-preset-wind-missing-tsconfig branch February 27, 2022 19:37
userquin added a commit that referenced this pull request Mar 14, 2022
Related to #659, just check the errors on windows on that PR.

/cc @hannoeru I can now build the project again on Windows 🙌
antfu pushed a commit that referenced this pull request Mar 15, 2022
Related to #659, just check the errors on windows on that PR.

/cc @hannoeru I can now build the project again on Windows 🙌
0x088730 pushed a commit to 0x088730/unocss that referenced this pull request Sep 16, 2022
Related to unocss/unocss#659, just check the errors on windows on that PR.

/cc @hannoeru I can now build the project again on Windows 🙌
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants