Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: source map support for transformers #665

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

hannoeru
Copy link
Collaborator

No description provided.

@hannoeru hannoeru requested a review from antfu as a code owner February 28, 2022 10:25
@netlify
Copy link

netlify bot commented Feb 28, 2022

✔️ Deploy Preview for unocss ready!

🔨 Explore the source changes: ce466a4

🔍 Inspect the deploy log: https://app.netlify.com/sites/unocss/deploys/621d9dc881575c00085ad870

😎 Browse the preview: https://deploy-preview-665--unocss.netlify.app/

@antfu
Copy link
Member

antfu commented Feb 28, 2022

I think the core (aim to be lightweight) should not deps on magic-string but only the transformers.

@hannoeru
Copy link
Collaborator Author

hannoeru commented Feb 28, 2022

@antfu core package is only using types from magic-string, and magic-string is only installed as dependencies on vite package.

@antfu
Copy link
Member

antfu commented Mar 1, 2022

@hannoeru @chu121su12 Can you help resolve this conflict? 😅

@chu121su12 chu121su12 force-pushed the feat/source-map-support-for-transform-directives branch from e375a13 to f40430b Compare March 1, 2022 04:06
@antfu antfu merged commit 9ddd2e8 into main Mar 1, 2022
@antfu antfu deleted the feat/source-map-support-for-transform-directives branch March 1, 2022 04:41
@antfu
Copy link
Member

antfu commented Mar 1, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants