Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR - Passwords protected by a Master Password! It's not #58

Closed
doa379 opened this issue Dec 21, 2019 · 8 comments
Closed

ERROR - Passwords protected by a Master Password! It's not #58

doa379 opened this issue Dec 21, 2019 · 8 comments

Comments

@doa379
Copy link

doa379 commented Dec 21, 2019

I am running on Linux Deb10 with Firefox-ESR (68). I get the error when trying to decrypt one of my profiles. There is no Master Password set in Firefox. I was able to decrypt another profile successfully.

Master Password for profile 
2019-12-21 12:38:35,926 - WARNING - Attempting decryption with no Master Password
2019-12-21 12:38:35,929 - ERROR - Password decryption failed. Passwords protected by a Master Password!

I ran tests/run_all:

decrypt/tests$ ./run_all
Passed:                            33
Failed:                             0
Unexpected successes:               0
Skipped:                            0
Expected failures:                  0
Runtime:                         2.09 seconds
@unode
Copy link
Owner

unode commented Dec 31, 2019

Hi @doa379 , I'm using the same browser, version and also using a profile without password and cannot reproduce the problem.

Try running: firefox_decrypt.py -vvv for extra debugging information.

@ghost
Copy link

ghost commented Jan 6, 2020

Hello,
having exact same issue:

$ ./run_all Passed: 33 Failed: 0 Unexpected successes: 0 Skipped: 0 Expected failures: 0 Runtime: 1.73 seconds

Please find output of -vvv flag:
https://pastebin.com/w2Ywuu2M

@unode
Copy link
Owner

unode commented Jan 6, 2020

Hi @iketanijus,

From the log it's using libnss in the system library path. Do you by any chance have libnss installed through your system's package manager?

@ghost
Copy link

ghost commented Jan 6, 2020

Yes, I am using Slackware64-14.2 Linux. It has libnss3.so library provided by mozilla-nss-3.40.1-x86_64 package by default.

@unode
Copy link
Owner

unode commented Jan 6, 2020

@iketanijus unless I'm misunderstanding. On the log, you didn't provide a master password but the username later on is still encrypted.

The tests above also passed so there is either a problem with your password input or your profile.

@ghost
Copy link

ghost commented Jan 6, 2020

Yes, I did not provide any password (just hit enter key on prompt), because that profile does not have any master password set actually. If I start Firefox from that profile, then I can see all the saved passwords without entering any master password. Still script complains that it's set for some reason, while it is certainly not.

@unode
Copy link
Owner

unode commented Jan 6, 2020

I'm using nss-3.46.1 here and everything works as expected. In the past we had users reporting problems when using libnss installed with the system's package manager. I've managed to reproduce it on Fedora but if compiled manually it worked fine so it was some kind of packaging incompatibility. In this case tests pass, so it seems like it's a different problem.

A few steps you can try to troubleshoot this:

  1. chdir into the folder where firefox/thunderbird is installed. Check that libnss.so is present and run firefox_decrypt from that location.
  2. Create a new empty profile and add save a password without adding a master password. Check if the same problem appears.
  3. Download NSS from here, compile manually and try running the script with this libnss.so.

If all still fail, could you share the profile you created in 2 so I can try to reproduce it on my side?

@unode
Copy link
Owner

unode commented Apr 15, 2021

This should be fixed in the latest version.

@unode unode closed this as completed Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants