Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM][Toggle Light/Dark] Toggle does not have rounded corners #55

Closed
1 of 6 tasks
agneszitte opened this issue Oct 27, 2020 · 3 comments · Fixed by unoplatform/uno#4419
Closed
1 of 6 tasks

[WASM][Toggle Light/Dark] Toggle does not have rounded corners #55

agneszitte opened this issue Oct 27, 2020 · 3 comments · Fixed by unoplatform/uno#4419
Assignees
@carldebilly
Labels
kind/regression Something was working, now it isn't
Milestone
3.2

Comments

@agneszitte
Copy link
Contributor

Current behavior

Light/Dark theme toggle does not have rounded corners for WASM

image

Expected behavior

Toggle Light/Dark theme toggle should have rounded corners for WASM

image

How to reproduce it (as minimally and precisely as possible)

Launch Uno Gallery and notice the Light/Dark theme toggle.

Environment

Devcies:

Nuget Package: Uno.UI

Package Version(s): latest dev

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renders for Xamarin.Forms
  • Windows
  • Build tasks

Anything else we need to know?

Missing overflow: hidden; for the Grid.
image
@agneszitte agneszitte added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Oct 27, 2020
@agneszitte agneszitte added platform/wasm kind/regression Something was working, now it isn't and removed kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Oct 27, 2020
@agneszitte agneszitte added this to the 3.2 milestone Oct 27, 2020
@jeromelaban
Copy link
Member

This is fixed in latest Uno @carldebilly, isn't it ?

@agneszitte
Copy link
Contributor Author

@jeromelaban it was fixed for Border but not for Grid normally if I'm not mistaking @carldebilly

@agneszitte
Copy link
Contributor Author

agneszitte commented Oct 27, 2020 •
edited
Loading

@jeromelaban
@carldebilly is also looking at this issue at the same time => #37

@carldebilly carldebilly mentioned this issue Oct 29, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carldebilly carldebilly

Labels
kind/regression Something was working, now it isn't
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

New UI Tests for CornerRadius unoplatform/uno
3 participants
@carldebilly @jeromelaban @agneszitte