Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: InfoBar Fluent samples #308

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Nov 24, 2021

GitHub Issue (If applicable): #252

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

InfoBar has only Material samples

What is the new behavior?

InfoBar has Fluent samples too.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@morning4coffe-dev
Copy link
Member

Currently the page was reworked like this. The flexibility issue has been fixed here #812
image

@Xiaoy312
Copy link
Contributor

the "options" panel should push the content aside, and not overlay on top of original content

@morning4coffe-dev
Copy link
Member

@Xiaoy312 Thanks for pointing this out, this issue has been fixed with the #812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants