chore: Upgrade - WebRTC.Wasm Sample to run with latest uno and latest VS 2022 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure to use the name of the sample you're upgrading in the PR title. Also, it looks like we missed previously missed this sample for the upgrade (or that we missed it when it was first integrated). Good that we're updating this one now :) |
|
@jeromelaban , Okay I will do one PR for each integration. Ad back to the first to do "exclusion" to the legacy folder. Despite that, I'm stuck with this error: I will time-box, update and test for two hours, document the issues, and move away to the next when consistently get no success. Sounds good the plan?
|
aesteves900
changed the title
|
Where is this error coming from? Is this for this sample specificall? Can you show the complete error ? |
aesteves900
force-pushed
the
dev/AEST/152-update-uno-lastest-version
branch
from
428af62
to
90bc0f9
Compare
jeromelaban
reviewed
Oct 11, 2022
chore: Upgrade - Web RTC Sample to run with latest uno and latest VS 2022 chore: Upgrade all samples to run with latest uno and latest VS 2022
aesteves900
force-pushed
the
dev/AEST/152-update-uno-lastest-version
branch
from
e927e94
to
3a328ca
Compare
jeromelaban
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.