chore: MapControl Sample - Update to net6 #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeromelaban should we convert this sample to use something like mapsui? or should we just archive this sample |
|
@nickrandolph @aesteves900 Let's convert it to use mapsui, now that it's supported! |
agneszitte
reviewed
Jan 24, 2023
UI/MapControlSample/MapControlSample/MapControlSample.Mobile/Android/Assets/AboutAssets.txt
Outdated
Show resolved
Hide resolved
UI/MapControlSample/MapControlSample/MapControlSample.Shared/App.xaml.cs
Outdated
Show resolved
Hide resolved
UI/MapControlSample/MapControlSample/MapControlSample.Shared/App.xaml.cs
Outdated
Show resolved
Hide resolved
…ndroid/Assets/AboutAssets.txt Co-authored-by: Agnès ZITTE <16295702+agneszitte-nventive@users.noreply.github.com>
…pp.xaml.cs Co-authored-by: Agnès ZITTE <16295702+agneszitte-nventive@users.noreply.github.com>
…pp.xaml.cs Co-authored-by: Agnès ZITTE <16295702+agneszitte-nventive@users.noreply.github.com>
|
@aesteves900 did you get this to work for ios and android? I've added gtk and wpf target platforms and they work but I can't get android or ios to work |
|
Pushed this back to draft until issues with mapsui for ios/android are resolved |
@nickrandolph , I tested on Android and works properly, unfortunately, I have no device to test on iOS. I do double -check on |
nickrandolph
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the update for .NET6 the legacy MapControl becomes incompatible, then the solution was replace from MapControl to Mapsui compatible with WinUI and .NET 6
Closes #296